-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vindexes: fix pooled collator buffer memory leak #14621
Merged
vmg
merged 1 commit into
vitessio:release-18.0
from
Shopify:fix-unicode-loose-vindex-memory-leak-v18
Nov 27, 2023
Merged
vindexes: fix pooled collator buffer memory leak #14621
vmg
merged 1 commit into
vitessio:release-18.0
from
Shopify:fix-unicode-loose-vindex-memory-leak-v18
Nov 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brendan Dougherty <[email protected]>
brendar
requested review from
harshit-gangal,
systay,
frouioui and
GuptaManan100
as code owners
November 27, 2023 15:32
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 27, 2023
frouioui
added
Component: Query Serving
Type: Performance
Backport to: release-16.0
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
Backport to: release-18.0
labels
Nov 27, 2023
frouioui
approved these changes
Nov 27, 2023
vmg
approved these changes
Nov 27, 2023
vitess-bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
Signed-off-by: Brendan Dougherty <[email protected]>
vitess-bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
Signed-off-by: Brendan Dougherty <[email protected]>
frouioui
pushed a commit
that referenced
this pull request
Nov 28, 2023
…) (#14623) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
dbussink
pushed a commit
that referenced
this pull request
Nov 29, 2023
…) (#14622) Signed-off-by: Brendan Dougherty <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a memory leak in
unicode_loose_*
vindexes by resetting the buffer before returning the collator to the pool.This issue impacts v18 and below so I think it should be backported to v17 and v16 as well. As noted in the linked issue, the problem does not exist on
main
.Related Issue(s)
Fixes #14587
Checklist
Deployment Notes
n/a