-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evalengine: Fix the min / max calculation for decimals #14614
Merged
dbussink
merged 1 commit into
vitessio:main
from
planetscale:dbussink/fix-min-max-decimal
Nov 27, 2023
Merged
evalengine: Fix the min / max calculation for decimals #14614
dbussink
merged 1 commit into
vitessio:main
from
planetscale:dbussink/fix-min-max-decimal
Nov 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not storing the precision for the decimal here, resulting in accidentally rounding it. Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
requested review from
harshit-gangal,
systay,
frouioui and
GuptaManan100
as code owners
November 27, 2023 12:51
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 27, 2023
dbussink
added
Type: Bug
Component: Evalengine
changes to the evaluation engine
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Nov 27, 2023
vmg
approved these changes
Nov 27, 2023
systay
approved these changes
Nov 27, 2023
shlomi-noach
approved these changes
Nov 27, 2023
vitess-bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
Signed-off-by: Dirkjan Bussink <[email protected]>
JiekerTime
pushed a commit
to JiekerTime/vitess
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Dirkjan Bussink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not storing the precision for the decimal here, resulting in accidentally rounding it.
Related Issue(s)
Fixes #14608
Checklist