Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot connection: revert to explicit table locks when FTWRL is unavailable #14578

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Snapshot connection: revert to explicit table locks when FTWRL is unavailable #14578

merged 3 commits into from
Nov 23, 2023

Conversation

shlomi-noach
Copy link
Contributor

Description

When SnapshotConn needs to run FLUSH TABLES WITH READ LOCK (e.g. MoveTables --all-tables) and the command is rejected (as happens with RDS/Aurora), SnaposhotConn now reverts to issuing an explicit LOCK TABLES t1 READ, t2 READ, ... for all base tables.

Related Issue(s)

#14577

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VReplication labels Nov 22, 2023
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 22, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 22, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 22, 2023
@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 22, 2023
dbussink
dbussink reviewed Nov 22, 2023
View reviewed changes
go/vt/vttablet/tabletserver/vstreamer/snapshot_conn.go Outdated
}
query := fmt.Sprintf("lock tables %s", strings.Join(lockClauses, ","))
if _, err := lockConn.ExecuteFetch(query, 1, false); err != nil {
log.Infof("Error explicitly locking all %v tables", len(lockClauses))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this log.Errorf and also print the error as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Also added check for empty table list.

@shlomi-noach shlomi-noach requested a review from a team November 22, 2023 11:11
notfelineit
notfelineit approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@notfelineit notfelineit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@shlomi-noach shlomi-noach merged commit 8b7ed8d into vitessio:main Nov 23, 2023
115 checks passed
@shlomi-noach shlomi-noach deleted the snapshot-conn-explicit-locks branch November 23, 2023 20:04
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@shlomi-noach @ejortegau
Snapshot connection: revert to explicit table locks when FTWRL is u…
174ca1f 
…navailable (vitessio#14578)

Signed-off-by: Shlomi Noach <[email protected]>
@rohit-nayak-ps rohit-nayak-ps mentioned this pull request Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notfelineit notfelineit notfelineit approved these changes

@vmg vmg vmg approved these changes

@dbussink dbussink dbussink approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shlomi-noach @dbussink @vmg @notfelineit