Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online DDL: recognize shorter vitess artifact table name #14571

Closed

Conversation

shlomi-noach
Copy link
Contributor

Description

Initial support for #14570. This PR merely recognizes this new shorter naming scheme as an OnlineDDL table name, .e.g _4e5dcf80_354b_11eb_82cd_f875a4d24e90_20201203114013_vrp.

This name is two characters shorter than the current scheme (e.g. _4e5dcf80_354b_11eb_82cd_f875a4d24e90_20201203114013_vrepl). It allows default constraint names with one or two digits. For example:

mysql> create table _84371a37_6153_11eb_9917_f875a4d24e90_20210128122816_vrp(id int primary key, pid int, foreign key (pid) references p(id));
Query OK, 0 rows affected (0.06 sec)

mysql> show create table _84371a37_6153_11eb_9917_f875a4d24e90_20210128122816_vrp\G
*************************** 1. row ***************************
       Table: _84371a37_6153_11eb_9917_f875a4d24e90_20210128122816_vrp
Create Table: CREATE TABLE `_84371a37_6153_11eb_9917_f875a4d24e90_20210128122816_vrp` (
  `id` int NOT NULL,
  `pid` int DEFAULT NULL,
  PRIMARY KEY (`id`),
  KEY `pid` (`pid`),
  CONSTRAINT `_84371a37_6153_11eb_9917_f875a4d24e90_20210128122816_vrp_ibfk_1` FOREIGN KEY (`pid`) REFERENCES `p` (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci

The name _84371a37_6153_11eb_9917_f875a4d24e90_20210128122816_vrp_ibfk_1 is 63 characters long, and thus we can support up to _84371a37_6153_11eb_9917_f875a4d24e90_20210128122816_vrp_ibfk_99 with this naming scheme.

This PR only accepts this new naming scheme. A followup PR will actually use it.

Related Issue(s)

#14570

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach added Type: Bug Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) labels Nov 21, 2023
@shlomi-noach shlomi-noach requested a review from a team November 21, 2023 18:43
@shlomi-noach shlomi-noach self-assigned this Nov 21, 2023
Copy link
Contributor

vitess-bot bot commented Nov 21, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 21, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 21, 2023
@rohit-nayak-ps rohit-nayak-ps removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 21, 2023
@deepthi
Copy link
Member

deepthi commented Nov 21, 2023

Leaving this to @shlomi-noach to merge or not (based on further developments / learnings on the topic).

@shlomi-noach shlomi-noach marked this pull request as draft November 22, 2023 12:29
@shlomi-noach
Copy link
Contributor Author

On hold while we debate #14582

@shlomi-noach
Copy link
Contributor Author

Closed in favor of #14613

@shlomi-noach shlomi-noach deleted the onlineddl-vrepl-internal-name branch November 27, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants