-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Online DDL: recognize shorter vitess artifact table name #14571
Closed
shlomi-noach
wants to merge
1
commit into
vitessio:main
from
planetscale:onlineddl-vrepl-internal-name
Closed
Online DDL: recognize shorter vitess artifact table name #14571
shlomi-noach
wants to merge
1
commit into
vitessio:main
from
planetscale:onlineddl-vrepl-internal-name
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
added
Type: Bug
Component: Online DDL
Online DDL (vitess/native/gh-ost/pt-osc)
labels
Nov 21, 2023
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 21, 2023
rohit-nayak-ps
approved these changes
Nov 21, 2023
rohit-nayak-ps
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Nov 21, 2023
4 tasks
deepthi
approved these changes
Nov 21, 2023
Leaving this to @shlomi-noach to merge or not (based on further developments / learnings on the topic). |
On hold while we debate #14582 |
Closed in favor of #14613 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial support for #14570. This PR merely recognizes this new shorter naming scheme as an OnlineDDL table name, .e.g
_4e5dcf80_354b_11eb_82cd_f875a4d24e90_20201203114013_vrp
.This name is two characters shorter than the current scheme (e.g.
_4e5dcf80_354b_11eb_82cd_f875a4d24e90_20201203114013_vrepl
). It allows default constraint names with one or two digits. For example:The name
_84371a37_6153_11eb_9917_f875a4d24e90_20210128122816_vrp_ibfk_1
is63
characters long, and thus we can support up to_84371a37_6153_11eb_9917_f875a4d24e90_20210128122816_vrp_ibfk_99
with this naming scheme.This PR only accepts this new naming scheme. A followup PR will actually use it.
Related Issue(s)
#14570
Checklist
Deployment Notes