Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysqlctl: Cleanup stale socket lockfile #14553

Merged
merged 1 commit into from
Nov 20, 2023
Merged

mysqlctl: Cleanup stale socket lockfile #14553

merged 1 commit into from
Nov 20, 2023

Conversation

dbussink
Copy link
Contributor

When we know the lock file is stale, we can clean it up safely inside mysqlctl so that we can safely start MySQL again.

Related Issue(s)

Fixes #14552

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 20, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 20, 2023
@dbussink dbussink added Type: Bug Component: TabletManager and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 20, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 20, 2023
GuptaManan100
GuptaManan100 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the tests, but I think having the comments in the code (that are there in the tests) would be benifitial. Rest looks good to me.

@dbussink dbussink force-pushed the dbussink/remove-stale-mysql-lockfile branch 2 times, most recently from 0fe3b79 to cab36c5 Compare November 20, 2023 13:28
@dbussink
mysqlctl: Cleanup stale socket lockfile
9e0d0fb 
When we know the lock file is stale, we can clean it up safely inside
`mysqlctl` so that we can safely start MySQL again.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the dbussink/remove-stale-mysql-lockfile branch from cab36c5 to 9e0d0fb Compare November 20, 2023 13:30
@dbussink
Copy link
Contributor Author

I love the tests, but I think having the comments in the code (that are there in the tests) would be benifitial. Rest looks good to me.

I have extensively commented it and added some more logging as well in case of errors.

@dbussink dbussink merged commit 1c5e487 into vitessio:main Nov 20, 2023
115 checks passed
@dbussink dbussink deleted the dbussink/remove-stale-mysql-lockfile branch November 20, 2023 15:50
This was referenced Nov 24, 2023
Open
Merged
ejortegau referenced this pull request in slackhq/vitess Dec 13, 2023
@dbussink @ejortegau
mysqlctl: Cleanup stale socket lockfile (#14553)
6fe1858 
Signed-off-by: Dirkjan Bussink <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@systay systay systay approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

Assignees
No one assigned
Labels
Component: TabletManager Type: Bug
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

Bug Report: When using MySQL without mysqld_safe a stale lock file prevents restarts
3 participants
@dbussink @systay @GuptaManan100