MysqlCtl: implement missing ReadBinlogFilesTimestamps
function
#14525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per #14506, calls to
ReadBinlogFilesTimestamps
failed withrpc error: code = Unimplemented desc = method ReadBinlogFilesTimestamps not implemented
.This affects users of
mysqlctld
, but was not detected inendtoend
tests, which were not using the same.The function is added and now tested.
A
release-18.0
backport is needed, but also requires a backwards-compatibility fix to17.0
, because the functionReadBinlogFilesTimestamps
is new tov18
. A special PR for 18 release to follow.Related Issue(s)
Checklist
Deployment Notes