Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fast_analyze_table variable, introduced in public MySQL fork #14494

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

shlomi-noach
Copy link
Contributor

Description

This PR follows up on #13352. It utilizes fast_analyze_table (global/session variable), introduced in planetscale/mysql-server@c8a9d93 as part of https://github.com/planetscale/mysql-server/releases/tag/8.0.34-ps1.

In this PR, and when --analyze-table DDL strategy flag is provided, the Online DDL executor checks for existence of this variable. If the variable exists, then the executor will set it to 1 prior to running ANALYZE TABLE ....

This introduced code is safe to run on MySQL versions that do not support the variable, as the initial probing query is

show global variables like 'fast_analyze_table'

which is always safe to run. The query returns 0 rows on unsupporting servers.

With fast_analyze_table, an ANALYZE TABLE only updates stats for the clustering index (normally the PRIMARY KEY).

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) labels Nov 8, 2023
Copy link
Contributor

vitess-bot bot commented Nov 8, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 8, 2023
@shlomi-noach shlomi-noach requested review from dbussink and a team November 8, 2023 13:50
@shlomi-noach shlomi-noach changed the title Support fast_analyze_table variable in public fork Support fast_analyze_table variable, introduced in public MySQL fork Nov 8, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 8, 2023
@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 8, 2023
@deepthi deepthi merged commit 76299df into vitessio:main Nov 14, 2023
117 of 119 checks passed
@deepthi deepthi deleted the onlineddl-fast-analyze-table branch November 14, 2023 20:06
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants