Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce wait time in test helpers #14476

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Reduce wait time in test helpers #14476

merged 4 commits into from
Nov 15, 2023

Conversation

dbussink
Copy link
Contributor

@dbussink dbussink commented Nov 6, 2023

Instead of waiting already before we check, immediately check and then start waiting if we need to. This avoids waiting neednessly which slows down tests.

Also shorten the wait loop time to 100ms instead of 1s to speed things up even if we have to wait.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@dbussink
Reduce wait time in test helpers
e7303a5 
Instead of waiting already before we check, immediately check and then
start waiting if we need to. This avoids waiting neednessly which slows
down tests.

Also shorte the wait loop time to 100ms instead of 1s to speed things up
even if we have to wait.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink added Type: Testing Component: General Changes throughout the code base labels Nov 6, 2023
@dbussink dbussink requested a review from deepthi as a code owner November 6, 2023 14:08
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 6, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 6, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 6, 2023
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 6, 2023
@frouioui
Copy link
Member

LGTM! Thank you

dbussink
dbussink commented Nov 15, 2023
View reviewed changes
Copy link
Contributor Author

@dbussink dbussink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@GuptaManan100
Copy link
Member

I have verified the test isn't flaky anymore with the recent changes. It has passed successively 5 times as compared to failing almost all the time.

@dbussink dbussink merged commit 09bd94a into vitessio:main Nov 15, 2023
115 checks passed
@dbussink dbussink deleted the dbussink/improve-test-waits branch November 15, 2023 21:10
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@dbussink @GuptaManan100 @ejortegau
Reduce wait time in test helpers (vitessio#14476)
22e4c20 
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 left review comments

@frouioui frouioui frouioui approved these changes

@ajm188 ajm188 ajm188 approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Type: Testing
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dbussink @frouioui @GuptaManan100 @shlomi-noach @ajm188