vtctldclient: Apply tablet type filtering for keyspace+shard in GetTablets #14467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Lord <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
Signed-off-by: Matt Lord <[email protected]>
mattlord
added
Backport to: release-18.0
and removed
NeedsWebsiteDocsUpdate
Signed-off-by: Matt Lord <[email protected]>
mattlord
added
Type: Bug
Component: CLI
Component: vtctldclient
and removed
NeedsDescriptionUpdate
rohit-nayak-ps
approved these changes
Nov 5, 2023
deepthi
approved these changes
Nov 5, 2023
vitess-bot
pushed a commit
that referenced
this pull request
Nov 5, 2023
…blets (#14467) Signed-off-by: Matt Lord <[email protected]>
mattlord
added a commit
that referenced
this pull request
Nov 8, 2023
…+shard in GetTablets (#14467) (#14470) Signed-off-by: Matt Lord <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <[email protected]>
ajm188
reviewed
Nov 15, 2023
| @@ -2016,6 +2018,9 @@ func (s *VtctldServer) GetTablets(ctx context.Context, req *vtctldatapb.GetTable | |||
|
|
|||
| tablets := make([]*topodatapb.Tablet, 0, len(tabletMap)) | |||
| for _, ti := range tabletMap { | |||
| if req.TabletType != 0 && ti.Type != req.TabletType { | |||
There was a problem hiding this comment.
why is this 0 and not UNKNOWN?
There was a problem hiding this comment.
Only because I copied the existing check/filter that was already used elsewhere in the function.🙂 I wish that I had changed both locations instead though. Whomever changes this file next should do that.
There was a problem hiding this comment.
Since it's a non-functional change I snuck it in here:
459a27b
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
You can filter tablets by keyspace, shard, and tablet-type with the
GetTabletscommand.There is a different path taken when keyspace and shard are both specified, however, and in that path the tablet type filtering was not done. This PR corrects that and applies the tablet type filtering everywhere if requested.
Related Issue(s)
Checklist