Support for MySQL MAX_EXECUTION_TIME as query timeout method

[timvaillancourt]

Description

This PR implements #12518 by allowing the MySQL Optimizer Hint MAX_EXECUTION_TIME(<millis>), based on the existing vttablet query timeout (seconds) to be automatically added to queries using when the new --query-timeout-method flag is set to mysql (default vttablet)

The vttablet will wait up to --query-timeout-seconds + 1 for MySQL to do this, before falling back to the existing behaviour that issues a MySQL KILL operation

Suggestions on how to make the PR more robust is appreciated 🙇

Related Issue(s)

#12518

Checklist

• "Backport to:" labels have been added if this change should be back-ported
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on the CI
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[timvaillancourt]

Planning to get this ready to review shortly, some tweaks needed first

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[timvaillancourt]

Bump, still planning to complete this

[timvaillancourt]

I plan to wrap this up once I can figure out a smart way to add optimizer hints on the vttablet level. It seems vtgate has logic to add optimizer hints but it's not clear in vttablet

I'm curious if @harshit-gangal has time for a quick chat about that detail?

[harshit-gangal]

I plan to wrap this up once I can figure out a smart way to add optimizer hints on the vttablet level. It seems vtgate has logic to add optimizer hints but it's not clear in vttablet

I'm curious if @harshit-gangal has time for a quick chat about that detail?

VTGate and VTTablet already have a flag for query timeouts query-timeout and queryserver-config-query-timeout.
Currently, the VTGate flag is used to set the context timeout eventually a Kill on MySQL and the VTTablet flag is used to execute the Kill on MySQL.
The current VTTablet flag can be used to repurpose it for select queries. We can modify the Build method in go/vt/vttablet/tabletserver/planbuilder/plan.go to add the optimizer hint.

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[github-actions]

This PR was closed because it has been stale for 7 days with no activity.