Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement --max-report-sample-rows for VDiff #14437

Merged
merged 10 commits into from
Nov 24, 2023
Merged

implement --max-report-sample-rows for VDiff #14437

merged 10 commits into from
Nov 24, 2023

Conversation

mcrauwel
Copy link
Contributor

@mcrauwel mcrauwel commented Nov 2, 2023 •
edited by mattlord
Loading

Description

implement --max-report-sample-rows for VDiff to allow more than 10 rows to be displayed in the VDiff report

Related Issue(s)

Fixes #14323

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 2, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 2, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 2, 2023
@mcrauwel mcrauwel changed the title implement --max-vdiff-report-rows for VDiff implement --max-report-sample-rows for VDiff Nov 2, 2023
mattlord
mattlord reviewed Nov 2, 2023
View reviewed changes
go/vt/vtctl/vdiff2.go Show resolved Hide resolved
go/vt/vtctl/vdiff2.go Outdated Show resolved Hide resolved
go/vt/vtctl/vdiff2.go Outdated Show resolved Hide resolved
go/vt/vttablet/tabletmanager/vdiff/table_differ.go Outdated Show resolved Hide resolved
go/vt/vttablet/tabletmanager/vdiff/workflow_differ.go Outdated Show resolved Hide resolved
proto/tabletmanagerdata.proto Outdated Show resolved Hide resolved
@mcrauwel mcrauwel force-pushed the mcrauwel/max-vdiff-report-rows branch from 91fc1f0 to d7948fc Compare November 2, 2023 16:41
@mcrauwel mcrauwel requested a review from notfelineit as a code owner November 2, 2023 17:32
@mattlord mattlord added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VReplication and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request labels Nov 3, 2023
mattlord
mattlord reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! We just need to trim the changes down and consider the vitess decision to avoid unsigned values in almost all cases.

go/vt/vtctl/vdiff2.go Outdated Show resolved Hide resolved
proto/tabletmanagerdata.proto Show resolved Hide resolved
go/vt/vtctl/vdiff2.go Show resolved Hide resolved
go/cmd/vtctldclient/command/vreplication/vdiff/vdiff.go Outdated Show resolved Hide resolved
@mcrauwel mcrauwel force-pushed the mcrauwel/max-vdiff-report-rows branch from 53fc130 to 736bafe Compare November 14, 2023 07:42
@mattlord mattlord self-requested a review November 16, 2023 13:40
mattlord
mattlord reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only had a couple of minor nits about types and names. Let me know if I'm missing something or you disagree.

Otherwise if you can make those last changes then I'll approve and have Rohit review tomorrow when we are working together. ❤️

go/cmd/vtctldclient/command/vreplication/vdiff/vdiff.go Outdated Show resolved Hide resolved
go/cmd/vtctldclient/command/vreplication/vdiff/vdiff.go Outdated Show resolved Hide resolved
proto/tabletmanagerdata.proto Outdated Show resolved Hide resolved
@mattlord mattlord removed the NeedsWebsiteDocsUpdate What it says label Nov 17, 2023
@mattlord
Copy link
Contributor

I removed the NeedsWebsiteDocs label as we only changed vtctldclient and the docs for that will get updated automatically.

mattlord
mattlord approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @mcrauwel!

@rohit-nayak-ps
Trigger rebuild
35d2bfa 
Signed-off-by: Rohit Nayak <[email protected]>
@rohit-nayak-ps
Copy link
Contributor

Triggering rebuild because one of the required tests refused to run.

@rohit-nayak-ps rohit-nayak-ps merged commit e08d151 into vitessio:main Nov 24, 2023
118 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the mcrauwel/max-vdiff-report-rows branch November 24, 2023 14:11
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@mcrauwel @rohit-nayak-ps @ejortegau
implement --max-report-sample-rows for VDiff (vitessio#14437)
bc83e8a 
Signed-off-by: Matthias Crauwels <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Co-authored-by: Rohit Nayak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@mattlord mattlord mattlord approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

Assignees
No one assigned
Labels
Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
VReplication
Status: Done
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

Feature Request: add support for syncing table row-differences after VDiff
3 participants
@mcrauwel @mattlord @rohit-nayak-ps