Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tabletserver: do not consolidate streams on primary tablet when consolidator mode is notOnPrimary #14332

Merged
merged 3 commits into from
Dec 5, 2023
Merged

tabletserver: do not consolidate streams on primary tablet when consolidator mode is notOnPrimary #14332

merged 3 commits into from
Dec 5, 2023

Conversation

maxenglander
Copy link
Collaborator

@maxenglander maxenglander commented Oct 22, 2023 •
edited
Loading

Description

Currently the primary will consolidate stream executions when --enable_consolidator=false and --enable_consolidator_replicas=true because tabletserver is not passing tabletType when constructing QueryExecutor.

This PR:

  • Passes tabletType when constructing QueryExecutor in stream execution context.
  • Records StreamConsolidations to wait timings.

Related Issue(s)

Fixes #14331

Checklist

Deployment Notes

@maxenglander
tabletserver: no consolidate streams primary if --enable_consolidator…
7d1f448 
…=false

Currently the primary will consolidate stream executions when
--enable_consolidator=false and --enable_consolidator_replicas=true
because tabletserver is not passing tabletType when constructing
QueryExecutor.

Signed-off-by: Max Englander <[email protected]>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 22, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 22, 2023
@maxenglander maxenglander changed the title tabletserver: no consolidate streams primary if --enable_consolidator=false tabletserver: no consolidate streams primary if --enable_consolidator=false and --enable_consolidator_replicas=true Oct 22, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Oct 22, 2023
@maxenglander maxenglander mentioned this pull request Oct 22, 2023
Merged
@maxenglander maxenglander marked this pull request as ready for review October 22, 2023 13:13
@maxenglander maxenglander changed the title tabletserver: no consolidate streams primary if --enable_consolidator=false and --enable_consolidator_replicas=true tabletserver: no consolidate streams primary when consolidator mode notOnPrimary Oct 23, 2023
@deepthi deepthi changed the title tabletserver: no consolidate streams primary when consolidator mode notOnPrimary tabletserver: do not consolidate streams on primary tablet when consolidator mode is notOnPrimary Oct 31, 2023
@maxenglander
merge <- main
1ac2354 
Signed-off-by: Max Englander <[email protected]>
@ajm188 ajm188 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Dec 4, 2023
GuptaManan100
GuptaManan100 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! The tests are specifically very well written.

@systay systay merged commit fe01a76 into vitessio:main Dec 5, 2023
116 of 117 checks passed
@systay systay deleted the maxeng-stream-qe-pass-tablet-type branch December 5, 2023 09:35
This was referenced Dec 5, 2023
Closed
Merged
Merged
maxenglander added a commit that referenced this pull request Dec 5, 2023
@maxenglander
tabletserver: do not consolidate streams on primary tablet when conso…
9d379c4 
…lidator mode is `notOnPrimary` (#14332)

Signed-off-by: Max Englander <[email protected]>
maxenglander added a commit that referenced this pull request Dec 5, 2023
@maxenglander
tabletserver: do not consolidate streams on primary tablet when conso…
e6c9e3c 
…lidator mode is `notOnPrimary` (#14332)

Signed-off-by: Max Englander <[email protected]>
maxenglander added a commit that referenced this pull request Dec 5, 2023
@maxenglander
tabletserver: do not consolidate streams on primary tablet when conso…
0eb867f 
…lidator mode is `notOnPrimary` (#14332)
maxenglander added a commit to planetscale/vitess that referenced this pull request Dec 5, 2023
@maxenglander
tabletserver: do not consolidate streams on primary tablet when conso…
ee02e8d 
…lidator mode is `notOnPrimary` (vitessio#14332)

Signed-off-by: Max Englander <[email protected]>
@maxenglander maxenglander mentioned this pull request Dec 5, 2023
Merged
GuptaManan100 pushed a commit that referenced this pull request Dec 5, 2023
@vitess-bot @maxenglander
[release-18.0] tabletserver: do not consolidate streams on primary ta…
7df54df 
…blet when consolidator mode is `notOnPrimary` (#14332) (#14679)

Signed-off-by: Max Englander <[email protected]>
Co-authored-by: Max Englander <[email protected]>
GuptaManan100 pushed a commit that referenced this pull request Dec 5, 2023
@vitess-bot @maxenglander
[release-17.0] tabletserver: do not consolidate streams on primary ta…
f5d68d8 
…blet when consolidator mode is `notOnPrimary` (#14332) (#14678)

Signed-off-by: Max Englander <[email protected]>
Co-authored-by: Max Englander <[email protected]>
systay pushed a commit that referenced this pull request Dec 5, 2023
@maxenglander
[release-16.0] tabletserver: do not consolidate streams on primary ta…
b635041 
…blet when consolidator mode is `notOnPrimary` (#14332) (#14683)
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@maxenglander @ejortegau
tabletserver: do not consolidate streams on primary tablet when conso…
5929d42 
…lidator mode is `notOnPrimary` (vitessio#14332)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@ajm188 ajm188 ajm188 approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

Bug Report: primary consolidates stream executions when consolidator mode is notOnPrimary
5 participants
@maxenglander @ajm188 @GuptaManan100 @systay @frouioui