Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: Remove dependencies installed by
make tools
#14309Tools: Remove dependencies installed by
make tools
#14309Changes from 2 commits
7877cb4
9ad4dbc
fd79a71
64d7eb6
b7353f8
037e3d9
4d1cd5a
66533b1
675de0f
b6c8994
c290572
1102d60
e6130fd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like it's here because of assumption in line 30? We don't need to make that assumption IMO. We could instead
pushd ${VTROOT}
and thenpopd
at the end to put the user back where they started.IMO it's also worth doing some basic checks if we do set VTROOT by looking for some expected dir contents (e.g. the tools subdir). We're removing a lot of files, so IMO it's worth being extra safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that line is no longer needed as from now onwards this file will be invocated by
Makefile