Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VReplication: VTTablet flag cleanup #14297

Merged
merged 4 commits into from
Nov 15, 2023
Merged

VReplication: VTTablet flag cleanup #14297

merged 4 commits into from
Nov 15, 2023

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Oct 17, 2023 •
edited
Loading

Description

This PR removes some long deprecated flags and deprecates another: --vreplication_tablet_type, which at this point only causes confusion as it's entirely unnecessary/unused.

Documentation updated here: vitessio/website#1623

Related Issue(s)

Checklist

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 17, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 17, 2023
@mattlord mattlord added Type: Internal Cleanup Component: VReplication and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Oct 17, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Oct 17, 2023
@mattlord mattlord force-pushed the vreplication_tablet_flag_cleanup branch from 40bd693 to 2af4d07 Compare October 17, 2023 16:05
@mattlord
Cleanup vreplication tablet flags.
c6a626b 
Remove long deprecated flags and deprecate additional
unnecessary ones.

Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord force-pushed the vreplication_tablet_flag_cleanup branch from 2af4d07 to c6a626b Compare October 17, 2023 16:26
@mattlord
Update release summary
9a70085 
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord marked this pull request as ready for review October 17, 2023 18:35
mattlord added a commit to vitessio/website that referenced this pull request Oct 17, 2023
@mattlord
Update docs for changes made in vitessio/vitess#14297
24d86bb 
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord mentioned this pull request Oct 17, 2023
Merged
@mattlord mattlord changed the title VRepliation: VTTablet flag cleanup VReplication: VTTablet flag cleanup Oct 17, 2023
@mattlord
Add comment
1aaaba8 
Signed-off-by: Matt Lord <[email protected]>
deepthi pushed a commit to vitessio/website that referenced this pull request Nov 7, 2023
@mattlord
Update docs for changes made in vitessio/vitess#14297 (#1623)
acb5e4e
ajm188
ajm188 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with the pflag api change

go/vt/vttablet/tabletmanager/vreplication/flags.go Outdated
fs.IntVar(&vreplicationParallelInsertWorkers, "vreplication-parallel-insert-workers", vreplicationParallelInsertWorkers, "Number of parallel insertion workers to use during copy phase. Set <= 1 to disable parallelism, or > 1 to enable concurrent insertion during copy phase.")

// Deprecated and ignored in v19.
fs.String("vreplication_tablet_type", tabletTypesStr, "Deprecated: comma separated list of tablet types used as a source (ignored)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the "deprecated" text from the usage and prefer fs.MarkDeprecated

@ajm188 ajm188 force-pushed the vreplication_tablet_flag_cleanup branch from 2d60cfd to 1aaaba8 Compare November 15, 2023 19:47
@ajm188
Copy link
Contributor

ajm188 commented Nov 15, 2023

(my bad)

deprecate flag
b115ecc 
Signed-off-by: Andrew Mason <[email protected]>
@ajm188 ajm188 merged commit 5a93514 into vitessio:main Nov 15, 2023
115 checks passed
@ajm188 ajm188 deleted the vreplication_tablet_flag_cleanup branch November 15, 2023 21:40
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@mattlord @ejortegau
VReplication: VTTablet flag cleanup (vitessio#14297)
fd04502 
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Co-authored-by: Andrew Mason <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajm188 ajm188 ajm188 approved these changes

@deepthi deepthi deepthi approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber

@vmg vmg Awaiting requested review from vmg

@derekperkins derekperkins Awaiting requested review from derekperkins

@dkhenry dkhenry Awaiting requested review from dkhenry

Assignees
No one assigned
Labels
Component: VReplication Type: Internal Cleanup
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mattlord @ajm188 @deepthi