Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onlineddl_vrepl_stress: fix flakiness caused by timeouts #14295

Merged
merged 2 commits into from
Oct 17, 2023
Merged

onlineddl_vrepl_stress: fix flakiness caused by timeouts #14295

merged 2 commits into from
Oct 17, 2023

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Oct 17, 2023 •
edited
Loading

Description

This PR fixes once observed flakiness in onlineddl_vrepl_stress CI test, caused by a timeout. The main fix here is to exit when the context is cancelled, before checking the error code.
While at it, I've simplified the timeout mechanism to rely solely on context.WithTimeout() or context.WithCancel() and removed some superfluous code.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach requested a review from a team October 17, 2023 10:40
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 17, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 17, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Oct 17, 2023
rohit-nayak-ps
rohit-nayak-ps approved these changes Oct 17, 2023
View reviewed changes
go/test/endtoend/onlineddl/vrepl_stress/onlineddl_vrepl_mini_stress_test.go Outdated
return
case <-time.After(singleConnectionSleepInterval):
}
if !errors.Is(err, context.DeadlineExceeded) { // this is an acceptable error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are handling ctx.Done() just above and returning, when will it come here with a DeadlineExceeded?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right. Removing the if condition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Oct 17, 2023
@shlomi-noach
no need to check for context.DeadlineExceeded because we exist in cas…
2bb752b 
…e of deadline before looking into the error

Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach shlomi-noach removed the NeedsIssue A linked issue is missing for this Pull Request label Oct 17, 2023
@shlomi-noach shlomi-noach merged commit e7aaa5b into vitessio:main Oct 17, 2023
115 of 116 checks passed
@shlomi-noach shlomi-noach deleted the onlineddl-vrepl-stress-flaky-fix branch October 17, 2023 16:40
@shlomi-noach shlomi-noach mentioned this pull request Oct 18, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@mattlord mattlord mattlord approved these changes

Assignees
No one assigned
Labels
Component: Build/CI Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: CI/Build
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shlomi-noach @mattlord @rohit-nayak-ps