refactor: move more code from logical plans to ops #14287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
systay
added
Type: Internal Cleanup
Component: Query Serving
and removed
NeedsDescriptionUpdate
systay
requested review from
harshit-gangal,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
systay
changed the title
frouioui
reviewed
Oct 17, 2023
Comment on lines
+460
to
+467
| scatterAsWarns := directives.IsSet(sqlparser.DirectiveScatterErrorsAsWarnings) | ||
| timeout := queryTimeout(directives) | ||
| multiShardAutoCommit := directives.IsSet(sqlparser.DirectiveMultiShardAutocommit) | ||
| return &queryHints{ | ||
| scatterErrorsAsWarnings: scatterAsWarns, | ||
| multiShardAutocommit: multiShardAutoCommit, | ||
| queryTimeout: timeout, | ||
| } |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
frouioui
reviewed
Oct 17, 2023
Comment on lines
+784
to
+797
| if err != nil { | ||
| return nil, vterrors.Wrap(err, "unexpected expression in LIMIT") | ||
| } | ||
| plan.elimit.Count = pv | ||
|
|
||
| if limit.Offset != nil { | ||
| pv, err = evalengine.Translate(limit.Offset, nil) | ||
| if err != nil { | ||
| return nil, vterrors.Wrap(err, "unexpected expression in OFFSET") | ||
| } | ||
| plan.elimit.Offset = pv | ||
| } | ||
|
|
||
| return plan, nil |
There was a problem hiding this comment.
Shouldn't we use vterrors errors here?
There was a problem hiding this comment.
I just moved this method from postprocess.go. It's not wrong to use Wrap, right?
frouioui
approved these changes
Oct 17, 2023
GuptaManan100
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have good support for rewriting our query plans in the operator side of the planner. This PR moves a few constructs that were still planned on the logicalPlan structures over to the operators.
The remaining responsibility of the logicalPlan implementations is now to build the engine primitive tree.
Related Issue(s)
Tracking issue #11626
Checklist
Deployment Notes