-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken link in docker readme #14222
Fix broken link in docker readme #14222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thank you! However, the DCO check is failing, can you please amend your commit and sign it.
Done! |
Hey @ravicodelabs it seems like the DCO check is still failing. Please follow the instructions on https://github.com/vitessio/vitess/pull/14222/checks?check_run_id=17579049266. |
Hi @frouioui, sorry for the back and forth! I've added the Signed-off-by line as well, so hopefully it should go through this time. |
It went through! Thank you 🙏🏻 We will get you a second review, and then we can merge this. |
Signed-off-by: Florent Poinsard <[email protected]>
I force pushed to your branch @ravicodelabs to re-trigger CI as it was stuck for some reason. |
Done @ravicodelabs, thank you for your contribution! 🚀 |
Description
This is a fix of a broken link in the docker readme. In particular, the third bullet under the "Principles" heading links to [lite/build.sh](https://github.com/vitessio/vitess/blob/main/docker/lite/build.sh, which does not exist, and is therefore substituted with another
build.sh
file link that works.Related Issue(s)
Fixes #14221
Checklist