Gracefully shutdown VTGate instances #14220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
* Release notes for 15.0.0-rc1 Signed-off-by: Rameez Sajwani <[email protected]> * Release commit for 15.0.0-rc1 Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]>
vitessio#11448) * feat: call the logic for waiting for shard locks on synchronous on-term hooks and add tests for it Signed-off-by: Manan Gupta <[email protected]> * feat: fix comment for acceptSighupSignal function Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
… creation (vitessio#11415) (vitessio#11447) * Testing.... Signed-off-by: Matt Lord <[email protected]> * Setup reverse routing rules at the start of the first partial movetables. Enhance e2e test to test for this as well as switch the remaining shard so that all shards are switched Signed-off-by: Rohit Nayak <[email protected]> * Update display representation of state for partially moved keyspaces Signed-off-by: Rohit Nayak <[email protected]> * Test improvements Signed-off-by: Matt Lord <[email protected]> * Cleanup shard routing rules on cancel/complete Signed-off-by: Matt Lord <[email protected]> * Cleanup intermediate changes Signed-off-by: Matt Lord <[email protected]> * Fix DryRun TrafficSwitcher and its tests Signed-off-by: Matt Lord <[email protected]> * Support concurrent partial movetables for N keyspaces And other minor changes after self review Signed-off-by: Matt Lord <[email protected]> * Avoid unnecessary save + rebuild steps Signed-off-by: Matt Lord <[email protected]> * Add secondary ordering for shard routing rules on to_keyspace Signed-off-by: Matt Lord <[email protected]> * Minor changes after self review Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: Rohit Nayak <[email protected]> Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: Rohit Nayak <[email protected]>
…e correct binary. (vitessio#11450) Signed-off-by: Rohit Nayak <[email protected]> Signed-off-by: Rohit Nayak <[email protected]>
* Use JSON for plan tests Signed-off-by: Florent Poinsard <[email protected]> * move vschemas into single directory Signed-off-by: Andres Taylor <[email protected]> * indentation Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: FlorentP <[email protected]>
…ssio#11469) Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]>
This is to pick up the fix for golang/go#56152. Signed-off-by: Andrew Mason <[email protected]> Signed-off-by: Andrew Mason <[email protected]> Co-authored-by: Andrew Mason <[email protected]>
…nShard`, `GetFullStatus` (vitessio#11438) (vitessio#11452) * Add validate Signed-off-by: notfelineit <[email protected]> * Add validate to cluster page Signed-off-by: notfelineit <[email protected]> * Run lint prettier fix Signed-off-by: notfelineit <[email protected]> * Add UI for validate shard Signed-off-by: notfelineit <[email protected]> * Add validateShard Signed-off-by: notfelineit <[email protected]> * Run make web proto Signed-off-by: notfelineit <[email protected]> * Refactor validation results and implement validateShard Signed-off-by: notfelineit <[email protected]> * add http shards Signed-off-by: notfelineit <[email protected]> * Add GetFullStatus Signed-off-by: notfelineit <[email protected]> * Add keys and comment Signed-off-by: notfelineit <[email protected]> * Run lint prettier fix Signed-off-by: notfelineit <[email protected]> * Add ValidateVersionShard to vtctldclient Signed-off-by: notfelineit <[email protected]> * Add ValidateVersionShard Signed-off-by: notfelineit <[email protected]> * Update test for vtctldclient Signed-off-by: notfelineit <[email protected]> * Add test for ValidateVersionShard Signed-off-by: notfelineit <[email protected]> * run lint prettier fix again Signed-off-by: notfelineit <[email protected]> * Modify during 1:1 with gomez Signed-off-by: notfelineit <[email protected]> * Run lint prettier fix Signed-off-by: notfelineit <[email protected]> * Address PR review comments Signed-off-by: notfelineit <[email protected]> * Update indentation Signed-off-by: notfelineit <[email protected]> Signed-off-by: notfelineit <[email protected]> Co-authored-by: notfelineit <[email protected]>
* Fix check_make_sizegen Signed-off-by: Florent Poinsard <[email protected]> * Apply review suggestion Signed-off-by: Florent Poinsard <[email protected]> * Fail the static_check_etc workflow when a script fails Signed-off-by: Florent Poinsard <[email protected]> * Remove test code Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
…1483) * feat: add replacer and code to always print semi-sync fields and decode the io and sql state from integers to strings Signed-off-by: Manan Gupta <[email protected]> * refactor: prettify the changed file Signed-off-by: Manan Gupta <[email protected]> * feat: fix replication state strings and simplify code Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
…action Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
* Plan order by Count() Signed-off-by: Florent Poinsard <[email protected]> * Clean up the new aggregation E2E test Signed-off-by: Florent Poinsard <[email protected]> * Push more order by needs to the select list Signed-off-by: Florent Poinsard <[email protected]> * Remove unrequired code in TestOrderByCount Signed-off-by: Florent Poinsard <[email protected]> * remove unwanted directory Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
…k overflow (vitessio#11499) Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Andres Taylor <[email protected]>
* test: added failing e2e test Signed-off-by: Harshit Gangal <[email protected]> * log txID and reserveID in stream execute Signed-off-by: Harshit Gangal <[email protected]> * fix: maintain list of qd per key on the map and check for current connection id while removing Signed-off-by: Harshit Gangal <[email protected]> * added additional comments Signed-off-by: Harshit Gangal <[email protected]> Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
…ease-15.0 [release-15.0] fix: reserve connection to follow query timeout when outside of transaction (vitessio#11490)
* feat: added test for vtorc not being able to handle mutliple failures and fix it Signed-off-by: Manan Gupta <[email protected]> * test: fix code to delete rdonly tablet from the correct list Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
* Adding deprecate message to backup hooks Signed-off-by: Rameez Sajwani <[email protected]> * adding markdeprecated Signed-off-by: Rameez Sajwani <[email protected]> * fixing deprecation message Signed-off-by: Rameez Sajwani <[email protected]> * fixing messaging Signed-off-by: Rameez Sajwani <[email protected]> * fix flag name Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
* removing unncessary flags across binaries Signed-off-by: Rameez Sajwani <[email protected]> * code review feedback Signed-off-by: Rameez Sajwani <[email protected]> * fixing blank space Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]>
[15.0] Fix query list override issue on mysql restart (vitessio#11309)
* remove excessive logging Signed-off-by: Rameez Sajwani <[email protected]> * code feeback Signed-off-by: Rameez Sajwani <[email protected]> * fixing typo Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]>
…io#11493) * Move CI to mysql80 Signed-off-by: Rameez Sajwani <[email protected]> * fix typo Signed-off-by: Rameez Sajwani <[email protected]> * fixing typo Signed-off-by: Rameez Sajwani <[email protected]> * moving to apt-config 8.2 Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]>
I accidentally stumbled over the behavior outlined in `flag.PrintDefaults` [1], which `pflag` replicates, specifically: > The listed type, here int, can be changed by placing a back-quoted > name in the flag's usage string; the first such item in the message is > taken to be a parameter name to show in the message and the back quotes > are stripped from the message when displayed. [1]: https://pkg.go.dev/flag#PrintDefaults. Signed-off-by: Andrew Mason <[email protected]> Signed-off-by: Andrew Mason <[email protected]> Co-authored-by: Andrew Mason <[email protected]>
…th transaction (vitessio#11527) * fix: stream exec once in case of transactional connection Signed-off-by: Harshit Gangal <[email protected]> * test: added e2e test Signed-off-by: Harshit Gangal <[email protected]> * generate ci worflow Signed-off-by: Harshit Gangal <[email protected]> Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
…sue (vitessio#13735) Signed-off-by: Shlomi Noach <[email protected]>
…essio#13807) Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
vitessio#13813) (vitessio#13818) Signed-off-by: Andrew Mason <[email protected]> Co-authored-by: Andrew Mason <[email protected]>
…from schema tracker (vitessio#13673) (vitessio#13794) Co-authored-by: Harshit Gangal <[email protected]>
…postpone-completion strategy flag (vitessio#13832) Signed-off-by: Shlomi Noach <[email protected]> Co-authored-by: Deepthi Sigireddi <[email protected]> Co-authored-by: Andrew Mason <[email protected]>
… migrations (vitessio#13928) (vitessio#13935) Signed-off-by: Shlomi Noach <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Shlomi Noach <[email protected]>
…` folder is out-of-date (vitessio#14003) (vitessio#14004) Co-authored-by: Florent Poinsard <[email protected]>
…mode execution (vitessio#14012) (vitessio#14014) Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Harshit Gangal <[email protected]>
…itessio#14025) Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>
…ort `--retain-artifacts=<duration>` DDL strategy flag (vitessio#14029) (vitessio#14035) Signed-off-by: Shlomi Noach <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Shlomi Noach <[email protected]>
… all semi sync actions (vitessio#13075) (vitessio#13957) Co-authored-by: William Lu <[email protected]>
…frontmatter (vitessio#14056) (vitessio#14072) Signed-off-by: Andrew Mason <[email protected]> Co-authored-by: Andrew Mason <[email protected]>
…itessio#14104) Signed-off-by: Andrew Mason <[email protected]> Co-authored-by: Andrew Mason <[email protected]>
…re way (vitessio#14119) (vitessio#14120) Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Rohit Nayak <[email protected]>
…own within CI (vitessio#13793) (vitessio#14118) Co-authored-by: Matt Lord <[email protected]>
…14093) (vitessio#14115) Signed-off-by: Olga Shestopalova <[email protected]> Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Olga Shestopalova <[email protected]> Co-authored-by: Shlomi Noach <[email protected]> Co-authored-by: Matt Lord <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
…vitessio#14145) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…ces (vitessio#13654) (vitessio#14009) Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Brendan Dougherty <[email protected]> Signed-off-by: Austen Lacy <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Brendan Dougherty <[email protected]> Co-authored-by: Austen Lacy <[email protected]> Co-authored-by: Rohit Nayak <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
…itessio#11313) Add a VIndex option to skip verify-after-insert behavior when using INSERT...IGNORE or INSERT...ON DUPLICATE KEY UPDATE. Co-authored-by: Harshit Gangal <[email protected]> Co-authored-by: Jacques Grove <[email protected]> Signed-off-by: Max Englander <[email protected]> Signed-off-by: Max Englander <[email protected]>
DML to lookup VIndexes unconditionally takes a row lock on rows in the lookup VIndex backing table. Add an option to optionally elide this lock for cases where we know via business logic that the row will not be deleted, nor the lookup column changed. Signed-off-by: Max Englander <[email protected]> Signed-off-by: Max Englander <[email protected]>
Signed-off-by: Patrick Carnahan <[email protected]> Signed-off-by: Arthur Schreiber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Checklist
Deployment Notes