Migrate CreateLookupVindex and ExternalizeVindex to vtctldclient

[mattlord]

Description

vtctldclient is replacing the legacy vtctlclient. As part of that effort this PR migrates the CreateLookupVindex client command along with the associated ExternalizeVindex client command to vtctldclient.

Example

Here's a manual test that demonstrates the usage and the output:

cd examples/local

./101_initial_cluster.sh; mysql < ../common/insert_commerce_data.sql; ./201_customer_tablets.sh; ./202_move_tables.sh; sleep 5; ./203_switch_reads.sh; ./204_switch_writes.sh; ./205_clean_commerce.sh; ./301_customer_sharded.sh; ./302_new_shards.sh; ./303_reshard.sh; ./304_switch_reads.sh; ./305_switch_writes.sh; ./306_down_shard_0.sh; ./307_delete_shard_0.sh

vtctldclient --server localhost:15999 LookupVindex --name corder_lookup_vdx --table-keyspace customer create --keyspace customer --type consistent_lookup_unique --table-owner corder --table-owner-columns sku --table-name corder_lookup_tbl --table-vindex-type=unicode_loose_xxhash

vtctldclient --server localhost:15999 LookupVindex --name corder_lookup_vdx --table-keyspace customer externalize

vtctldclient --server localhost:15999 LookupVindex --name corder_lookup2_vdx --table-keyspace customer create --keyspace customer --type consistent_lookup_unique --table-owner corder --table-owner-columns sku --table-name corder_lookup2_tbl

vtctldclient --server localhost:15999 LookupVindex --name corder_lookup2_vdx --table-keyspace customer cancel

With the command output being:

LookupVindex corder_lookup_vdx created in the customer keyspace and the corder_lookup_vdx VReplication wokflow scheduled on the customer shards, use show to view progress

LookupVindex corder_lookup_vdx has been externalized and the corder_lookup_vdx VReplication workflow has been deleted

LookupVindex corder_lookup2_vdx created in the customer keyspace and the corder_lookup2_vdx VReplication wokflow scheduled on the customer shards, use show to view progress

LookupVindex corder_lookup2_vdx left in place and the corder_lookup2_vdx VReplication wokflow has been deleted

Note
This also implements the lookup table vindex type customization support from #14157 in vtctldclient

Related Issue(s)

• Fixes: Migrate CreateLookupVindex Command to Vtctldclient #12158
• Fixes: Migrate ExternalizeVindex Command to Vtctldclient #12164
• Related to: Allow specifying the hashing method for CreateLookupVindex #14157

Checklist

• "Backport to:" labels have been added if this change should be back-ported
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on the CI
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[rohit-nayak-ps]

lgtm