OnlineDDL: support --unsafe-allow-foreign-keys strategy flag #11976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
added
Type: Enhancement
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Shlomi Noach <[email protected]>
3 tasks
mattlord
approved these changes
Dec 21, 2022
go/vt/schema/ddl_strategy.go
Outdated
| @@ -173,6 +174,11 @@ func (setting *DDLStrategySetting) IsVreplicationTestSuite() bool { | |||
| return setting.hasFlag(vreplicationTestSuite) | |||
| } | |||
|
|
|||
| // IsAllowForeignKeysFlag checks if strategy options include -unsafe-allow-foreign-keys | |||
There was a problem hiding this comment.
Should be double dash, just for consistency (super minor).
There was a problem hiding this comment.
Added double-dash
deepthi
approved these changes
Dec 21, 2022
|
Not merging right now. @shlomi-noach can add the missing |
Signed-off-by: Shlomi Noach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A declarative enabling of foreign keys in
OnlineDDLobject and strategy. A new--unsafe-allow-foreign-keysallows, when specified, the existence of foreign key constraints in a DDL statement. Without this flag any foreign key definition return an error.The flag is intentionally prefixed with
unsafeto clearly indicate this is an incomplete work. We do not document this new flag in the meantime.Related Issue(s)
Foreign keys tracking issue: #11975
Checklist