Skip to content

Commit

Permalink
test: Remove unreachable test skipping (#16265)
Browse files Browse the repository at this point in the history
Signed-off-by: Graham Campbell <[email protected]>
  • Loading branch information
GrahamCampbell authored Jun 27, 2024
1 parent 2c8099b commit ddd1630
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
2 changes: 0 additions & 2 deletions go/test/endtoend/vtgate/queries/subquery/subquery_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,7 @@ func TestNotINQueries(t *testing.T) {

}

// Test only supported in >= v16.0.0
func TestSubqueriesExists(t *testing.T) {
utils.SkipIfBinaryIsBelowVersion(t, 16, "vtgate")
mcmp, closer := start(t)
defer closer()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -296,9 +296,6 @@ func TestDMLOnNewTable(t *testing.T) {

// TestNewView validates that view tracking works as expected.
func TestNewView(t *testing.T) {
utils.SkipIfBinaryIsBelowVersion(t, 16, "vtgate")
utils.SkipIfBinaryIsBelowVersion(t, 16, "vttablet")

ctx := context.Background()
conn, err := mysql.Connect(ctx, &vtParams)
require.NoError(t, err)
Expand All @@ -321,9 +318,6 @@ func TestNewView(t *testing.T) {

// TestViewAndTable validates that new column added in table is present in the view definition
func TestViewAndTable(t *testing.T) {
utils.SkipIfBinaryIsBelowVersion(t, 16, "vtgate")
utils.SkipIfBinaryIsBelowVersion(t, 16, "vttablet")

ctx := context.Background()
conn, err := mysql.Connect(ctx, &vtParams)
require.NoError(t, err)
Expand Down

0 comments on commit ddd1630

Please sign in to comment.