Add check for IsZero datetime in Fn_LAST_DAY

Signed-off-by: Noble Mittal <[email protected]>
vitessio · Jan 26, 2024 · c24efc8 · c24efc8
1 parent 2ea4596
commit c24efc8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/go/vt/vtgate/evalengine/compiler_asm.go b/go/vt/vtgate/evalengine/compiler_asm.go
@@ -3784,11 +3784,12 @@ func (asm *assembler) Fn_LAST_DAY() {
 			return 1
 		}
 		arg := env.vm.stack[env.vm.sp-1].(*evalTemporal)
-		d := lastDay(env.currentTimezone(), arg.dt)
-		if d.IsZero() {
+		if arg.dt.IsZero() {
 			env.vm.stack[env.vm.sp-1] = nil
 			return 1
 		}
+
+		d := lastDay(env.currentTimezone(), arg.dt)
 		env.vm.stack[env.vm.sp-1] = env.vm.arena.newEvalDate(d)
 		return 1
 	}, "FN LAST_DAY DATETIME(SP-1)")

diff --git a/go/vt/vtgate/evalengine/fn_time.go b/go/vt/vtgate/evalengine/fn_time.go
@@ -1228,10 +1228,6 @@ func (b *builtinLastDay) eval(env *ExpressionEnv) (eval, error) {
 	}
 
 	d := lastDay(env.currentTimezone(), dt.dt)
-	if d.IsZero() {
-		return nil, nil
-	}
-
 	return newEvalDate(d, env.sqlmode.AllowZeroDate()), nil
 }