support 'ALTER VITESS_MIGRATION FORCE_CUTOVER ALL'

Signed-off-by: Shlomi Noach <[email protected]>
vitessio · Nov 19, 2023 · 804b684 · 804b684
1 parent 0589d4a
commit 804b684
Show file tree

Hide file tree

Showing 9 changed files with 6,106 additions and 5,935 deletions.
diff --git a/go/cmd/vtctldclient/command/onlineddl.go b/go/cmd/vtctldclient/command/onlineddl.go
@@ -103,8 +103,8 @@ var (
 		RunE:                  commandOnlineDDLUnthrottle,
 	}
 	OnlineDDLForceCutOver = &cobra.Command{
-		Use:                   "force_cutover <keyspace> <uuid>",
-		Short:                 "Mark a given schema migration for corced cut-over.",
+		Use:                   "force_cutover <keyspace> <uuid|all>",
+		Short:                 "Mark a given schema migration, or all pending migration, for corced cut-over.",
 		Example:               "OnlineDDL force_cutover test_keyspace 82fa54ac_e83e_11ea_96b7_f875a4d24e90",
 		DisableFlagsInUseLine: true,
 		Args:                  cobra.ExactArgs(2),
@@ -193,12 +193,10 @@ func commandOnlineDDLCleanup(cmd *cobra.Command, args []string) error {
 }
 
 func commandOnlineDDLForceCutOver(cmd *cobra.Command, args []string) error {
-	keyspace := cmd.Flags().Arg(0)
-	uuid := cmd.Flags().Arg(1)
-	if !schema.IsOnlineDDLUUID(uuid) {
-		return fmt.Errorf("%s is not a valid UUID", uuid)
+	keyspace, uuid, err := analyzeOnlineDDLCommandWithUuidOrAllArgument(cmd)
+	if err != nil {
+		return err
 	}
-
 	cli.FinishedParsing(cmd)
 
 	resp, err := client.ForceCutOverSchemaMigration(commandCtx, &vtctldatapb.ForceCutOverSchemaMigrationRequest{

diff --git a/go/vt/sqlparser/ast_format.go b/go/vt/sqlparser/ast_format.go
@@ -291,6 +291,8 @@ func (node *AlterMigration) Format(buf *TrackedBuffer) {
 		alterType = "unthrottle all"
 	case ForceCutOverMigrationType:
 		alterType = "force_cutover"
+	case ForceCutOverAllMigrationType:
+		alterType = "force_cutover all"
 	}
 	buf.astPrintf(node, " %#s", alterType)
 	if node.Expire != "" {

diff --git a/go/vt/sqlparser/ast_format_fast.go b/go/vt/sqlparser/ast_format_fast.go
diff --git a/go/vt/sqlparser/constants.go b/go/vt/sqlparser/constants.go
@@ -929,6 +929,7 @@ const (
 	UnthrottleMigrationType
 	UnthrottleAllMigrationType
 	ForceCutOverMigrationType
+	ForceCutOverAllMigrationType
 )
 
 // ColumnStorage constants

diff --git a/go/vt/sqlparser/parse_test.go b/go/vt/sqlparser/parse_test.go
@@ -2421,6 +2421,8 @@ var (
 		input: "alter vitess_migration complete all",
 	}, {
 		input: "alter vitess_migration '9748c3b7_7fdb_11eb_ac2c_f875a4d24e90' cancel",
+	}, {
+		input: "alter vitess_migration force_cutover all",
 	}, {
 		input: "alter vitess_migration '9748c3b7_7fdb_11eb_ac2c_f875a4d24e90' force_cutover",
 	}, {