Skip to content

Commit

Permalink
resolved conflict
Browse files Browse the repository at this point in the history
Signed-off-by: Shlomi Noach <[email protected]>
  • Loading branch information
shlomi-noach committed Oct 31, 2024
1 parent 584ffa4 commit 7f85345
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions go/vt/vttablet/onlineddl/executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -954,17 +954,12 @@ func (e *Executor) cutOverVReplMigration(ctx context.Context, s *VReplStream, sh
return err
}
e.updateMigrationStage(ctx, onlineDDL.UUID, "waiting for post-sentry pos: %v", replication.EncodePosition(postSentryPos))
<<<<<<< HEAD
if err := waitForPos(s, postSentryPos); err != nil {
return err
=======
// We have not yet locked anything, stopped anything, or done anything that otherwise
// impacts query serving so we wait for a multiple of the cutover threshold here, with
// that variable primarily serving to limit the max time we later spend waiting for
// a position again AFTER we've taken the locks and table access is blocked.
if err := waitForPos(s, postSentryPos, migrationCutOverThreshold*3); err != nil {
return vterrors.Wrapf(err, "failed waiting for pos after sentry creation")

Check warning on line 962 in go/vt/vttablet/onlineddl/executor.go

View check run for this annotation

Codecov / codecov/patch

go/vt/vttablet/onlineddl/executor.go#L957-L962

Added lines #L957 - L962 were not covered by tests
>>>>>>> 4550640e08 (Improve Schema Engine's TablesWithSize80 query (#17066))
}
e.updateMigrationStage(ctx, onlineDDL.UUID, "post-sentry pos reached")
}
Expand Down

0 comments on commit 7f85345

Please sign in to comment.