vtctldclient,grpcvtctldserver ApplySchema: return unknown params from…

… grpcvtctldserver.ApplySchema, log them in vtctldclient.ApplySchema (#14672) Signed-off-by: Max Englander <[email protected]> Signed-off-by: Max Englander <[email protected]> Co-authored-by: Andrew Mason <[email protected]> Co-authored-by: Shlomi Noach <[email protected]>
vitessio · Dec 21, 2023 · 750d04c · 750d04c
1 parent cfa2079
commit 750d04c
Show file tree

Hide file tree

Showing 10 changed files with 2,959 additions and 2,004 deletions.
diff --git a/go/cmd/vtctldclient/command/vschemas.go b/go/cmd/vtctldclient/command/vschemas.go
@@ -113,11 +113,16 @@ func commandApplyVSchema(cmd *cobra.Command, args []string) error {
 	if err != nil {
 		return err
 	}
-	data, err := cli.MarshalJSON(res.VSchema)
+	vsData, err := cli.MarshalJSON(res.VSchema)
 	if err != nil {
 		return err
 	}
-	fmt.Printf("New VSchema object:\n%s\nIf this is not what you expected, check the input data (as JSON parsing will skip unexpected fields).\n", data)
+	fmt.Printf("New VSchema object:\n%s\nIf this is not what you expected, check the input data (as JSON parsing will skip unexpected fields).\n", vsData)
+	for vdxName, ups := range res.UnknownVindexParams {
+		for _, param := range ups.Params {
+			fmt.Printf("Unknown parameter in vindex %s: %s\n", vdxName, param)
+		}
+	}
 	return nil
 }
 

diff --git a/go/vt/proto/vtctldata/vtctldata.pb.go b/go/vt/proto/vtctldata/vtctldata.pb.go