Skip to content

Commit

Permalink
Remove unneeded loading of the MySQL driver
Browse files Browse the repository at this point in the history
These cases probably at some point actually used MySQL with Go's stdlib
`database/sql` logic, but no longer do.

This is mostly testing logic except for `vtorc`. The initial code port
from Orchestrator to `vtorc` likely kept the logic for a MySQL backend
but we've long since only had `vtorc` using `sqlite` internally.

Signed-off-by: Dirkjan Bussink <[email protected]>
  • Loading branch information
dbussink committed Mar 17, 2024
1 parent 51debbd commit 706b593
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion go/cmd/vtorc/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
package main

import (
_ "github.com/go-sql-driver/mysql"
_ "modernc.org/sqlite"

"vitess.io/vitess/go/cmd/vtorc/cli"
Expand Down
1 change: 0 additions & 1 deletion go/test/endtoend/vtgate/queries/timeout/timeout_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ package misc
import (
"testing"

_ "github.com/go-sql-driver/mysql"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

Expand Down
1 change: 0 additions & 1 deletion go/test/endtoend/vtorc/readtopologyinstance/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import (
"vitess.io/vitess/go/vt/vtorc/logic"
"vitess.io/vitess/go/vt/vtorc/server"

_ "github.com/go-sql-driver/mysql"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
_ "modernc.org/sqlite"
Expand Down

0 comments on commit 706b593

Please sign in to comment.