wip: Extend VSchema DDL to add/drop columns

Signed-off-by: David Piegza <[email protected]>
vitessio · Sep 22, 2023 · 6383f45 · 6383f45
1 parent a8f601d
commit 6383f45
Show file tree

Hide file tree

Showing 14 changed files with 8,042 additions and 7,900 deletions.
diff --git a/go/vt/sqlparser/ast.go b/go/vt/sqlparser/ast.go
@@ -451,6 +451,8 @@ type (
 
 		// AutoIncSpec is set for AddAutoIncDDLAction.
 		AutoIncSpec *AutoIncSpec
+
+		AlterOptions []AlterOption
 	}
 
 	// ShowMigrationLogs represents a SHOW VITESS_MIGRATION '<uuid>' LOGS statement

diff --git a/go/vt/sqlparser/ast_clone.go b/go/vt/sqlparser/ast_clone.go
diff --git a/go/vt/sqlparser/ast_copy_on_rewrite.go b/go/vt/sqlparser/ast_copy_on_rewrite.go
diff --git a/go/vt/sqlparser/ast_equals.go b/go/vt/sqlparser/ast_equals.go
diff --git a/go/vt/sqlparser/ast_format.go b/go/vt/sqlparser/ast_format.go
@@ -226,6 +226,8 @@ func (node *AlterVschema) Format(buf *TrackedBuffer) {
 		buf.astPrintf(node, "alter vschema add table %v", node.Table)
 	case DropVschemaTableDDLAction:
 		buf.astPrintf(node, "alter vschema drop table %v", node.Table)
+	case AlterVschemaTableDDLAction:
+		buf.astPrintf(node, "alter vschema table %v", node.Table)
 	case AddColVindexDDLAction:
 		buf.astPrintf(node, "alter vschema on %v add vindex %v (", node.Table, node.VindexSpec.Name)
 		for i, col := range node.VindexCols {

diff --git a/go/vt/sqlparser/ast_format_fast.go b/go/vt/sqlparser/ast_format_fast.go
diff --git a/go/vt/sqlparser/ast_funcs.go b/go/vt/sqlparser/ast_funcs.go
@@ -1261,6 +1261,8 @@ func (action DDLAction) ToString() string {
 		return AddVschemaTableStr
 	case DropVschemaTableDDLAction:
 		return DropVschemaTableStr
+	case AlterVschemaTableDDLAction:
+		return AlterVschemaTableStr
 	case AddColVindexDDLAction:
 		return AddColVindexStr
 	case DropColVindexDDLAction:

diff --git a/go/vt/sqlparser/ast_rewrite.go b/go/vt/sqlparser/ast_rewrite.go
diff --git a/go/vt/sqlparser/ast_visit.go b/go/vt/sqlparser/ast_visit.go
diff --git a/go/vt/sqlparser/cached_size.go b/go/vt/sqlparser/cached_size.go
diff --git a/go/vt/sqlparser/constants.go b/go/vt/sqlparser/constants.go
@@ -51,21 +51,22 @@ const (
 	VariableStr       = "variable"
 
 	// DDL strings.
-	CreateStr           = "create"
-	AlterStr            = "alter"
-	DeallocateStr       = "deallocate"
-	DropStr             = "drop"
-	RenameStr           = "rename"
-	TruncateStr         = "truncate"
-	FlushStr            = "flush"
-	CreateVindexStr     = "create vindex"
-	DropVindexStr       = "drop vindex"
-	AddVschemaTableStr  = "add vschema table"
-	DropVschemaTableStr = "drop vschema table"
-	AddColVindexStr     = "on table add vindex"
-	DropColVindexStr    = "on table drop vindex"
-	AddSequenceStr      = "add sequence"
-	AddAutoIncStr       = "add auto_increment"
+	CreateStr            = "create"
+	AlterStr             = "alter"
+	DeallocateStr        = "deallocate"
+	DropStr              = "drop"
+	RenameStr            = "rename"
+	TruncateStr          = "truncate"
+	FlushStr             = "flush"
+	CreateVindexStr      = "create vindex"
+	DropVindexStr        = "drop vindex"
+	AddVschemaTableStr   = "add vschema table"
+	DropVschemaTableStr  = "drop vschema table"
+	AlterVschemaTableStr = "alter vschema table"
+	AddColVindexStr      = "on table add vindex"
+	DropColVindexStr     = "on table drop vindex"
+	AddSequenceStr       = "add sequence"
+	AddAutoIncStr        = "add auto_increment"
 
 	// ALTER TABLE ALGORITHM string.
 	DefaultStr = "default"
@@ -486,6 +487,7 @@ const (
 	DropVindexDDLAction
 	AddVschemaTableDDLAction
 	DropVschemaTableDDLAction
+	AlterVschemaTableDDLAction
 	AddColVindexDDLAction
 	DropColVindexDDLAction
 	AddSequenceDDLAction