Skip to content

Commit

Permalink
bugfixes for error handling
Browse files Browse the repository at this point in the history
Signed-off-by: Andrew Mason <[email protected]>
  • Loading branch information
Andrew Mason committed Sep 20, 2023
1 parent 623f86c commit 5099f4f
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions go/cmd/vtcombo/cli/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import (
"github.com/spf13/cobra"

"vitess.io/vitess/go/acl"
"vitess.io/vitess/go/exit"
"vitess.io/vitess/go/mysql/replication"
"vitess.io/vitess/go/vt/dbconfigs"
"vitess.io/vitess/go/vt/log"
Expand Down Expand Up @@ -192,6 +191,9 @@ func run(cmd *cobra.Command, args []string) (err error) {

if startMysql {
mysqld.Mysqld, cnf, err = startMysqld(1)
if err != nil {
return err
}
servenv.OnClose(func() {
mysqld.Shutdown(context.TODO(), cnf, true)
})
Expand Down Expand Up @@ -287,7 +289,7 @@ func run(cmd *cobra.Command, args []string) (err error) {
// vtctld configuration and init
err = vtctld.InitVtctld(ts)
if err != nil {
exit.Return(1)
return err
}

if vschemaPersistenceDir != "" && !externalTopoServer {
Expand Down

0 comments on commit 5099f4f

Please sign in to comment.