Skip to content

Commit

Permalink
Modified the Pull Request review checklist to check for explicit Pull…
Browse files Browse the repository at this point in the history
… Request titles (#10485)

* added an item to the PR review checklist

Signed-off-by: Florent Poinsard <[email protected]>

* Improved english text in review checklist

Signed-off-by: Florent Poinsard <[email protected]>
  • Loading branch information
frouioui authored Jun 17, 2022
1 parent 932caf1 commit 4a4b32b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/comment_pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.
#### General
- [ ] Ensure that the Pull Request has a descriptive title.
- [ ] If this is a change that users need to know about, please apply the `release notes (needs details)` label so that merging is blocked unless the summary release notes document is included.
- [ ] If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
- [ ] If a workflow is added or modified, each items in `Jobs` should be named in order to mark it as `required`. If the workflow should be required, the GitHub Admin should be notified.
Expand Down

0 comments on commit 4a4b32b

Please sign in to comment.