Skip to content

Commit

Permalink
remove release.sh and update release docs
Browse files Browse the repository at this point in the history
Signed-off-by: Florent Poinsard <[email protected]>
  • Loading branch information
frouioui committed Oct 18, 2023
1 parent f83626f commit 2e74146
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 84 deletions.
5 changes: 1 addition & 4 deletions doc/internal/release/how-to-release.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,7 @@ On the release day, there are several things to do:
> - The benchmarks need to complete before announcing the blog posts or before they get cross-posted.
- **Go back to dev mode on the release branch.**
> - The version constants across the codebase must be updated to `SNAPSHOT`.
- **Build k8s Docker images and publish them.**
> - The docker image for `base`, `lite`, etc are built automatically by DockerHub. The k8s images however are dependent on these images and are required to be built manually.
> - These images should be built after the `base` image has been built and available on DockerHub.
> - To build and publish these images, checkout the new release tag that was just created and run `./release.sh` from the directory `./docker`.
- **Ensure the k8s images are available on DockerHub.**
- **Close the current GitHub Milestone**
> - Once we are done releasing the current version, we must close its corresponding GitHub Milestone as the development cycle for it is over.
> - **This does not apply if we are releasing an RC release.** For instance, if we are releasing `v18.0.0-rc1` we want to keep the `v18.0.0` milestone opened as development is not fully done for `v18.0.0`.
Expand Down
73 changes: 0 additions & 73 deletions docker/release.sh

This file was deleted.

1 change: 0 additions & 1 deletion tools/back_to_dev_mode.sh
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ fi
function doBackToDevMode () {
# Preparing the "dev mode" commit
updateJava $DEV_VERSION
updateDockerReleaseScript $DEV_VERSION
updateVersionGo $DEV_VERSION

git add --all
Expand Down
1 change: 0 additions & 1 deletion tools/create_release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ function createRelease () {
# Preparing the release commit
updateVitessExamples $RELEASE_VERSION $VTOP_VERSION
updateJava $RELEASE_VERSION
updateDockerReleaseScript $RELEASE_VERSION
updateVersionGo $RELEASE_VERSION

## Create the commit for this release and tag it
Expand Down
5 changes: 0 additions & 5 deletions tools/release_utils.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ function checkGitState() {
fi
}

function updateDockerReleaseScript () {
sed -i.bak -E "s/vt_base_version=.*/vt_base_version='v$1'/g" $ROOT/docker/release.sh
rm -f $ROOT/docker/release.sh.bak
}

function checkoutNewBranch () {
branch_name=$1

Expand Down

0 comments on commit 2e74146

Please sign in to comment.