Skip to content

Commit

Permalink
update with PR feedback and regenerate
Browse files Browse the repository at this point in the history
Signed-off-by: Andrew Mason <[email protected]>
  • Loading branch information
Andrew Mason committed Sep 20, 2023
1 parent ed83601 commit 15ae53d
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 8 deletions.
2 changes: 1 addition & 1 deletion go/cmd/vtbackup/cli/vtbackup.go
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ Whatever system launches vtbackup is responsible for the following:
- Retrying vtbackup if it fails.
- Alerting human operators if the failure is persistent.
The process vtbackup follows to take a new backup is as follows:
The process vtbackup follows to take a new backup has the following steps:
1. Restore from the most recent backup.
2. Start a mysqld instance (but no vttablet) from the restored data.
3. Instruct mysqld to connect to the current shard primary and replicate any
Expand Down
2 changes: 0 additions & 2 deletions go/cmd/vtclient/cli/vtclient.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ var (
Short: "vtclient connects to a vtgate server using the standard go driver API.",
Long: `vtclient connects to a vtgate server using the standard go driver API.
Version 3 of the API is used, we do not send any hint to the server.
For query bound variables, we assume place-holders in the query string
in the form of :v1, :v2, etc.`,
Example: `vtclient --server vtgate:15991 "SELECT * FROM messages"
Expand Down
2 changes: 1 addition & 1 deletion go/cmd/vtcombo/cli/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ var (
Long: `vtcombo is a single binary containing several vitess components.
In particular, it contains:
- A ZK topology server based on an in-memory map.
- A topology server based on an in-memory map.
- One vtgate instance.
- Many vttablet instances.
- A vtctld instance so it's easy to see the topology.`,
Expand Down
2 changes: 1 addition & 1 deletion go/flags/endtoend/vtbackup.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Whatever system launches vtbackup is responsible for the following:
- Retrying vtbackup if it fails.
- Alerting human operators if the failure is persistent.

The process vtbackup follows to take a new backup is as follows:
The process vtbackup follows to take a new backup has the following steps:
1. Restore from the most recent backup.
2. Start a mysqld instance (but no vttablet) from the restored data.
3. Instruct mysqld to connect to the current shard primary and replicate any
Expand Down
2 changes: 0 additions & 2 deletions go/flags/endtoend/vtclient.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
vtclient connects to a vtgate server using the standard go driver API.

Version 3 of the API is used, we do not send any hint to the server.

For query bound variables, we assume place-holders in the query string
in the form of :v1, :v2, etc.

Expand Down
2 changes: 1 addition & 1 deletion go/flags/endtoend/vtcombo.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
vtcombo is a single binary containing several vitess components.

In particular, it contains:
- A ZK topology server based on an in-memory map.
- A topology server based on an in-memory map.
- One vtgate instance.
- Many vttablet instances.
- A vtctld instance so it's easy to see the topology.
Expand Down

0 comments on commit 15ae53d

Please sign in to comment.