Skip to content

Commit

Permalink
vstreamer: rm excessive logging
Browse files Browse the repository at this point in the history
as is, this makes our vttablet logs unreadable when using message tables

Signed-off-by: Derek Perkins <[email protected]>
  • Loading branch information
derekperkins committed Dec 24, 2023
1 parent d807985 commit 025ad10
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions go/vt/vttablet/tabletserver/vstreamer/snapshot_conn.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,18 +116,15 @@ func (conn *snapshotConn) startSnapshot(ctx context.Context, table string) (gtid
defer func() {
_, err := lockConn.ExecuteFetch("unlock tables", 0, false)
if err != nil {
log.Warning("Unlock tables failed: %v", err)
} else {
log.Infof("Tables unlocked: %v", table)
log.Warning("Unlock tables (%s) failed: %v", table, err)
}
lockConn.Close()
}()

tableName := sqlparser.String(sqlparser.NewIdentifierCS(table))

log.Infof("Locking table %s for copying", table)
if _, err := lockConn.ExecuteFetch(fmt.Sprintf("lock tables %s read", tableName), 1, false); err != nil {
log.Infof("Error locking table %s to read", tableName)
log.Warningf("Error locking table %s to read: %v", tableName, err)
return "", err
}
mpos, err := lockConn.PrimaryPosition()
Expand Down

0 comments on commit 025ad10

Please sign in to comment.