Refactor Hero #566
Merged
Refactor Hero #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
frouioui
reviewed
Jul 8, 2024
frouioui
reviewed
Jul 8, 2024
frouioui
reviewed
Jul 8, 2024
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
frouioui
reviewed
Jul 8, 2024
There was a problem hiding this comment.
I left some comments mostly about the description of some Hero just so they match the text written on the Figma board. Feel free to update them on this PR or just update them when you go over each page.
Moreover, it seems like we are missing the new hero for the query plans comparison, is that planned for later or was that an oversight?
website/src/pages/ForeignKeysPage/components/ForeignKeysHero.tsx
Outdated
Show resolved
Hide resolved
Good point, I just forgot to do it! |
Signed-off-by: Jad Chahed <[email protected]>
frouioui
reviewed
Jul 8, 2024
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Make a generic Hero component and update all existing Heros
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?