Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support to unsupported python and django versions #950

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

jairhenrique
Copy link
Contributor

@vitalik
Copy link
Owner

vitalik commented Nov 22, 2023

I would keep for now python3.7 (I still see 1.5% of downloads using it) and it is supported by pydantic

and django ~3.1 is still used in the wild (as I know from some feedbacks)

So i would rather keep deps as it is - to give people less headaches migrating to ninja-v1

on the other hand django 2.x and 3.0 can be dropped (but then need to cleanup ninja.compatibility package)

@jairhenrique jairhenrique force-pushed the drop-support branch 6 times, most recently from 811d9fb to b300d75 Compare November 22, 2023 17:03
@jairhenrique
Copy link
Contributor Author

@vitalik done!

@vitalik vitalik merged commit 05f9e35 into vitalik:master Nov 23, 2023
23 of 24 checks passed
@vitalik
Copy link
Owner

vitalik commented Nov 23, 2023

Thank you

@jairhenrique jairhenrique deleted the drop-support branch November 23, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants