Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#822 "ValidationError" and "HttpError" are not unpicklable #838

Merged
merged 1 commit into from
Aug 31, 2023
Merged

#822 "ValidationError" and "HttpError" are not unpicklable #838

merged 1 commit into from
Aug 31, 2023

Conversation

AlTosterino
Copy link
Contributor

I'm using loguru for logging and had hard time debugging TypeError: ValidationError.__init__() missing 1 required positional argument: 'errors' while calling logger.exception in Ninja api.on_exception. This is addressing the issue.

Fixes #822

@OtherBarry
Copy link
Contributor

Minor nitpick, but it should be picklable and unpicklable, with an L, according to the python documentation.

@AlTosterino AlTosterino changed the title #822 "ValidationError" and "HttpError" are not unpickable #822 "ValidationError" and "HttpError" are not unpicklable Aug 31, 2023
@AlTosterino
Copy link
Contributor Author

@OtherBarry Oh my I didn't even notice... Thanks!

I also deleted __reduce__ method as super().__init__(...) did the trick 👌

@vitalik vitalik merged commit 3f5ccab into vitalik:master Aug 31, 2023
37 checks passed
@vitalik
Copy link
Owner

vitalik commented Aug 31, 2023

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] "ValidationError" and "HttpError" are not unpickable
3 participants