Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place pre-commit ruff before black because of its autofix #810

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Place pre-commit ruff before black because of its autofix #810

merged 2 commits into from
Aug 2, 2023

Conversation

pawelngei
Copy link
Contributor

Continuation of #805 :

Ruff's pre-commit hook should be placed after other formatting tools, such as Black and isort, unless you enable autofix, in which case, Ruff's pre-commit hook should run before Black, isort, and other formatting tools, as Ruff's autofix behavior can output code changes that require reformatting.

From https://github.com/astral-sh/ruff-pre-commit .

@vitalik vitalik merged commit 8bfe321 into vitalik:master Aug 2, 2023
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawelngei @vitalik