Fix no URL validation for ModelSchema URLFields #1255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1157
Since Django's implementation of of
get_internal_type()
returns 'CharField' forURLField
, we were not able to assign a more appropriate Pydantic type to it, such asAnyUrl
. As a result, there was no validation for URLs in post requests that expected a ModelSchema using URLFields.This PR fixes this by adding a special case for 'URLField' to check it's object type with and assign an
internal_type
of 'URLField'.Related tests were also updated.