Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paginating your endpoint transforms the collection return type into one that returns a dict, however, this isn't reflected in the final type.
Let's take this example:
This also leads to typing errors when passing in a pagination class (with Pyright):
This PR sets up overloading for
paginate
so that type can be correctly inferred in both cases. Operating under the assumption that assumption that ninja already makes thatpaginate_queryset
returnsdict[str, Any]
For our first example, we now get:
Other Changes
len
is supported. Therefore, I switched some of theQuerySet
types toSequence
to better reflect this.