Fix dict when validate assignment true #1024
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reported here.
This PR fixes an issue with v1.1.0 where setting validate_assignment = True on a Schema throws an Attribute error for dict on DjangoGetter. Example, from added test with change removed to force the error:
It appears this functionality was broken when GetterDict was removed as a parent from DjangoGetter, and adding dict in slots seems to be the easiest fix.
I'm very open to feedback, and if this is intended or what a better fix might be, this PR is just me taking a stab at fixing something needed by my company.
Note: It appears running the linting fixed a couple other linting issues unrelated to this change.