Fixed test coverage

vitalik · Sep 2, 2024 · 9a836db · 9a836db
1 parent 8bd6e9e
commit 9a836db
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/ninja/ordering_schema.py b/ninja/ordering_schema.py
@@ -1,4 +1,3 @@
-from abc import ABC, abstractmethod
 from typing import Any, List, TypeVar
 
 from django.db.models import QuerySet
@@ -9,7 +8,7 @@
 QS = TypeVar("QS", bound=QuerySet)
 
 
-class OrderingBaseSchema(Schema, ABC):
+class OrderingBaseSchema(Schema):
     order_by: List[str] = []
 
     class Config(Schema.Config):
@@ -28,7 +27,6 @@ def validate_order_by_field(cls, value: List[str]) -> List[str]:
 
         return value
 
-    @abstractmethod
     def sort(self, elements: Any) -> Any:
         raise NotImplementedError
 

diff --git a/tests/test_ordering_schema.py b/tests/test_ordering_schema.py
@@ -2,6 +2,7 @@
 from django.db.models import QuerySet
 
 from ninja import OrderingSchema
+from ninja.ordering_schema import OrderingBaseSchema
 
 
 class FakeQS(QuerySet):
@@ -83,3 +84,11 @@ def test_sort__should_call_order_by_on_queryset_with_expected_args():
     queryset = ordering_schema.sort(queryset)
     assert queryset.is_ordered
     assert queryset.order_by_args == tuple(order_by_value)
+
+
+def test_sort__should_raise_not_implemented_error():
+    class DummyOrderingSchema(OrderingBaseSchema):
+        pass
+
+    with pytest.raises(NotImplementedError):
+        DummyOrderingSchema().sort(FakeQS())