embl taxonomy plugin sync fixes

[dbushell]

This should stop the timeout issue #520

[sandykadam]

Thanks @dbushell
This looks very good improvement. Do you think it is good to show the count of records processing in popup window.

Also on other note, if you remember we built the microsite dyanamically whenever there is new website or if we need to update latest version. We have deployment scripts where we use wpcli commands to do all those changes required for deployment.

• With your above change, will following command still work.
• Is there way we can have custom wpcli command to update taxonomy from cli, which will also work in similar batch process way.

# Configure taxonomy
echo "=== Taxonomy ==="
echo "Taxonomy - configuring"
wp option update embl_taxonomy $VF_API_URL"pattern.json?pattern=embl-ontology&source=contenthub"
wp option update _options_embl_taxonomy field_embl_taxonomy
wp option update _options_embl_taxonomy_term_who field_embl_taxonomy_term_who
wp option update _options_embl_taxonomy_term_what field_embl_taxonomy_term_what
wp option update _options_embl_taxonomy_term_where field_embl_taxonomy_term_where

# Sync with the latest taxonomy from the contentHub
echo "Updating Taxonomy from ContentHub"
wp eval 'embl_taxonomy()->register->sync_taxonomy();'

[dbushell]

Hi @sandykadam yes I will add some kind of UI update to show a progress number

The wp option update commands will still work - nothing has changed there

wp eval 'embl_taxonomy()->register->sync_taxonomy();

This one wont work anymore.

Do you know if the bash script was timing out? Or was the timeout just syncing from the WP admin?

If the bash script synced without any timeouts I can add this back quickly so it continues to work the same.

Otherwise we'd have to write a new script to perform multi requests. I need to update the plugin first to allow that.

[dbushell]

Actually it would be easier if I wrote a PHP script to handle the multiple sync requests, then the bash part can remain a single wp eval

but if it was never timing out here I can revert to the old method quickly

[sandykadam]

Yes this is working fine no issues wp eval 'embl_taxonomy()->register->sync_taxonomy();'

[dbushell]

Yes this is working fine no issues wp eval 'embl_taxonomy()->register->sync_taxonomy();'

@sandykadam Just to clarify, I mean before this PR, was the old version syncing without timeout?

with this PR the sync will silently fail at the moment (I think) it won't complete the whole sync anyway

[sandykadam]

Yes this is working fine no issues wp eval 'embl_taxonomy()->register->sync_taxonomy();'

@sandykadam Just to clarify, I mean before this PR, was the old version syncing without timeout?

with this PR the sync will silently fail at the moment (I think) it won't complete the whole sync anyway

Yes from CLI it was working, it was only the admin UI was timing out, which I think will get fix with your batch process.

[dbushell]

The CLI sync now works like before:
wp eval 'embl_taxonomy()->register->sync_taxonomy();'

I've added sync progress:

And term select should now be filtered by the parent term:

[kasprzyk-sz]

Hey @david, I noticed that for the pages we have two fields for taxonomy. One at the bottom and one on the sidebar:

For pages, I think the bottom one is used to overwrite default breadcrumbs, right @sandeep?

For the posts, currently there is only the one on the sidebar. We use this field to tag articles with relevant terms.

Would you be able to improve it in the same way as the one on pages and move it to the bottom?

[sandykadam]

I was checking this change on local, I can see progress bar, cli change but I don't see the UI change for the taxonomy fields in settings page.

[dbushell]

@kasprzyk-sz I'm not sure that sidebar panel should be there. It certainly shouldn't say "ADD NEW..." because it's not possible to add new. Can you remember if this was always visible?

[kasprzyk-sz]

@dbushell yes, it was always there. We use this one though only for tagging posts on the news theme. I think @sandykadam meant actually this picker.

[dbushell]

@sandykadam it should look like this and be filtered by Who/What/Where:

If it's not updating can you check this page:

/wp-admin/edit.php?post_type=acf-field-group

and if "EMBL Taxonomy Terms" is listed under the default "All" view then hover over it and click "Trash"

it should then load properly from the JSON config file. Those settings don't need to be sync to the database, only when editing them.

[dbushell]

@kasprzyk-sz ah that one I haven't changed. It's just the default tag picker. There's no way to improve that.

It would be possible to make an alternate UI using ACF to manage tags, but it'd take a while to develop and test.