Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten crashing CLI #17423

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Laganellac
Copy link
Contributor

Description

This is a potential fix for #17381, and may need to be iterated on.

I updated avtFlattenQuery to only set the XmlResult in the QueryAttributes object if there is a valid results vector.

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Other

How Has This Been Tested?

I applied the change and rebuilt and retested on my system (Ubuntu 18.04).

I do not currently have access to a Windows 10 environment to test this on.

Checklist:

  • I have followed the style guidelines of this project.~~
  • I have performed a self-review of my own code.~~
  • [] I have commented my code where applicable.
  • [ ] I have updated the release notes.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] I have added debugging support to my changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • I have confirmed new and existing unit tests pass locally with my changes.~~
  • [ ] I have added new baselines for any new tests to the repo.
  • [ ] I have NOT made any changes to protocol or public interfaces in an RC branch.
  • I have assigned reviewers (see VisIt's PR procedures for more information).~~

@biagas
Copy link
Contributor

biagas commented Feb 1, 2023

We should get this in.

@biagas biagas marked this pull request as ready for review February 1, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants