Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker build #485

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add docker build #485

wants to merge 5 commits into from

Conversation

mishadev
Copy link

@mishadev mishadev commented Jun 5, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 89.944% when pulling 308fe63 on PhoboSys:add-docker-build into 043e68c on visionmedia:master.

rstacruz
rstacruz reviewed Jun 6, 2018
View reviewed changes
Dockerfile
@@ -0,0 +1,24 @@
FROM node:9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not node:8 (LTS) or node:10 (latest stable)?

Copy link
Member

@rstacruz rstacruz Jun 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, how do you build this? some instructions would be great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstacruz rstacruz rstacruz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mishadev @coveralls @rstacruz @BonBuasson