fix: address bug preventing url-form plugins/themes from installing

closes #176
visiblevc · Feb 13, 2020 · a6f1316 · a6f1316
1 parent 6a89c7d
commit a6f1316
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,12 @@
 # Changelog
 
-## 0.25.3 - latest
+## 0.25.4 - latest
+
+### Patch
+
+- Fix bug that prevented url form of plugins/themes to fail due to nullglob interacting with the parsing. #176
+
+## 0.25.3
 
 ### Patch
 

diff --git a/run.sh b/run.sh
@@ -1,5 +1,4 @@
 #!/bin/bash
-shopt -s nullglob
 
 if ! sudo mount -a 2> /dev/null; then
     printf '\e[1;31mERROR:\e[0m %s' \
@@ -179,7 +178,11 @@ init() {
     fi
 }
 
-check_database() {
+# this is ran in a subshell to isolate nullglob as it for whatever reason
+# interacts with our $PLUGINS and $THEMES variables.
+# See: https://github.com/visiblevc/wordpress-starter/issues/176
+check_database() (
+    shopt -s nullglob
     declare file
     declare -i num_imported=0
 
@@ -209,7 +212,7 @@ check_database() {
         h2 'Updating database...'
         wp core update-db |& logger
     fi
-}
+)
 
 check_plugins() {
     declare key