Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: only use maplibre v5 on Maplibre example #9354

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

felixpalmer
Copy link
Collaborator

Background

Using Maplibre v5 in the website breaks all the examples that are using it, as react-map-gl/maplibre has not yet been updated. Rather than changing all the react-map-gl/maplibre imports to @vis.gl/react-maplibre'; (like in the Maplibre example), this PR only imports the new Maplibre for the example that explicitly needs it. We will follow up and change this to the react-map-gl/maplibre import once v5 is available via that package

Change List

  • Add v5 import in example & example as alias
  • Reference alias in example

@coveralls
Copy link

coveralls commented Jan 15, 2025

Coverage Status

coverage: 91.636%. remained the same
when pulling 14b5dec on felix/website-maplibre-v5
into 7d046e6 on master.

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the last stumbling block for 9.1 release I think it makes sense to do this now and perhaps follow up with a "running" change once any necessary publishing has been done.

@felixpalmer felixpalmer merged commit 3744d89 into master Jan 16, 2025
4 checks passed
@felixpalmer felixpalmer deleted the felix/website-maplibre-v5 branch January 16, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants