Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: STADTKLN-61 final homepage design #13

Merged
merged 8 commits into from
Sep 12, 2024
Merged

feat: STADTKLN-61 final homepage design #13

merged 8 commits into from
Sep 12, 2024

Conversation

paulovareiro29
Copy link
Collaborator

No description provided.

@paulovareiro29 paulovareiro29 marked this pull request as ready for review September 10, 2024 10:17
@paulovareiro29
Copy link
Collaborator Author

@koepferd This PR is ready for review.
This PR has already changed the theme colors according to the design.

koepferd
koepferd requested changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@koepferd koepferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some spacing on the heros' image not fitting the full screen size. Please take a look at that.
Screenshot 2024-09-10 at 16 09 40

Second thing:
the only color contrast issue is the blue in the dark footer, which we need to discuss.
Screenshot 2024-09-10 at 16 20 52

src/partials/base/b_hero.twig Outdated Show resolved Hide resolved
src/pages/dataset.twig Outdated Show resolved Hide resolved
src/pages/dataset.twig Show resolved Hide resolved
src/pages/index.twig Outdated Show resolved Hide resolved
koepferd
koepferd requested changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@koepferd koepferd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color contrast look good now.
On small screens the hero background works, I tested on my external display and it still breaks from the vw being larger than 1936px. Please recheck.
Screenshot 2024-09-12 at 16 38 39

koepferd
koepferd approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@koepferd koepferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hero background issue due to bootstrap component was discussed with ux/ui.

@paulovareiro29 paulovareiro29 merged commit afcebdd into main Sep 12, 2024
2 checks passed
@paulovareiro29 paulovareiro29 deleted the feat/STADTKLN-61-final-homepage-design branch September 12, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koepferd koepferd koepferd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulovareiro29 @koepferd