fix: delete rooms even if user is already deleted from MariaDB

virtualidentityag · Aug 22, 2024 · c07de3b · c07de3b
1 parent 3a287be
commit c07de3b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/...b/userservice/api/admin/service/rocketchat/RocketChatRemoveFromGroupOperationService.java b/...b/userservice/api/admin/service/rocketchat/RocketChatRemoveFromGroupOperationService.java
@@ -81,6 +81,12 @@ public void removeFromGroupAndIgnoreGroupNotFound() {
                 session.getGroupId(), consultants)));
   }
 
+  public void removeFromGroup() {
+      this.consultantsToRemoveFromSessions.forEach(
+          ((session, consultants) ->
+              removeConsultantsFromSessionGroup(session.getGroupId(), consultants)));
+    }
+
   /**
    * Removes the given consultant from Rocket.Chat group of given session with rollback on error.
    */

diff --git a/src/main/java/de/caritas/cob/userservice/api/facade/assignsession/AssignEnquiryFacade.java b/src/main/java/de/caritas/cob/userservice/api/facade/assignsession/AssignEnquiryFacade.java
@@ -163,7 +163,7 @@ private void removeUnauthorizedMembers(
             .onSessionConsultants(Map.of(session, consultantsToRemoveFromRocketChat));
 
     if (rcGroupId.equalsIgnoreCase(session.getGroupId())) {
-      rocketChatRemoveFromGroupOperationService.removeFromGroupAndIgnoreGroupNotFound();
+      rocketChatRemoveFromGroupOperationService.removeFromGroup();
     }
     if (rcGroupId.equalsIgnoreCase(session.getFeedbackGroupId())) {
       rocketChatRemoveFromGroupOperationService.removeFromFeedbackGroup();