feat: playwright setup first step #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koepferd
requested changes
Nov 21, 2024
| .getByLabel(/(passwort\s?wiederholen|repeat\s?password)/i) | ||
| .fill(password!); | ||
| await page | ||
| .getByLabel(/Ich habe die Datenschutzerklä|I have the Privacy policy/) |
There was a problem hiding this comment.
Please check on what you are checking. Someone can change the texts in Weblate which will then result in failing tests and development work needed.
There was a problem hiding this comment.
I would not recommend using .getByLabel in our setup
| const username = process.env.TEST_USERNAME; | ||
| const password = process.env.TEST_PASSWORD; | ||
| await page.goto(`${caritasRework.dev}`); | ||
| ensureLanguage(page); |
There was a problem hiding this comment.
We can start with this, but generally I would recommend having the tests working no matter what language is used.
tests/login/login.spec.ts
Outdated
| const password = process.env.TEST_PASSWORD; | ||
| await page.goto(`${caritasRework.dev}`); | ||
| ensureLanguage(page); | ||
| await page.getByLabel(/(user\s?name|benutzername)/i).fill(username!); |
There was a problem hiding this comment.
Rather go with something like searching input with id "username"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing pipelines github actions