-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amend Data Preparation guide #136
Conversation
…create placeholders for links and contents to come across the other guides
b9b4db5
to
14e0550
Compare
@clone95 let's start discussing the contents of this guide I have done lots of reorg and also added my own ideas to it. Although I keep thinking there are still small things I might have missed but together we can fill these missing parts. |
Let's also pick up tips from here https://www.linkedin.com/posts/shivan-kumar_datascience-machinelearning-deeplearning-activity-6732600618751442944-kNRY |
@clone95 please invite anyone else to review this PR if you feel the need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job! 💯
I list here some of the more general comments, but it's mostly a braindump for me. Soon I will build a very small "editorial" guide for contributing, with both stylistic and formatting guidelines ( #141 ). So these comments are direct most to the old "me" when I was writing the old versione of the guide 1 year ago :
- can't find some sections (like lowercaseUppercase..) in the final draft
- the web app shows the subtitle (in the contextual menu on the left) only if ## or # is used. with more or equal than 3#### it doesn't shows it
Formatting
- always use Virgilio as a third person, never 1st person ("I colleted for you..." --> "Virgilio collected for you...")
- very minor stylist corrections like "s" and "z"
- the formatting can be improved, using bold, italic, and splitting sentences
- avoid long periods
- avoid sentences with more than 1 or 2 dependant sentences. If it cannot be done, re-think the design of the sentence
- split groups of more than 3-4 lines of text
content/purgatorio/collect-and-prepare-data/data-preparation.md
Outdated
Show resolved
Hide resolved
content/purgatorio/collect-and-prepare-data/data-preparation.md
Outdated
Show resolved
Hide resolved
content/purgatorio/collect-and-prepare-data/data-preparation.md
Outdated
Show resolved
Hide resolved
content/purgatorio/collect-and-prepare-data/data-preparation.md
Outdated
Show resolved
Hide resolved
content/purgatorio/collect-and-prepare-data/data-preparation.md
Outdated
Show resolved
Hide resolved
content/purgatorio/collect-and-prepare-data/data-preparation.md
Outdated
Show resolved
Hide resolved
content/purgatorio/collect-and-prepare-data/data-preparation.md
Outdated
Show resolved
Hide resolved
content/purgatorio/collect-and-prepare-data/data-preparation.md
Outdated
Show resolved
Hide resolved
b69415a
to
819df7f
Compare
15ca65a
to
d33dde9
Compare
@clone95 Any more updates for this one before it can be merged? |
Nice Mani! I think we are close to ready. I will push a couple of formatting fixes, then I will merge the PR |
Adding Visualization sub-topic to Data preparation guide. Changes to create placeholders for links and contents to come across the other guides.
The overall structure and/or the content may change as new content gets closer to finalisation. But this is an evolving topic, so it's going to be continuously amended even after we merge the first finalised version.