-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Write out emojis to system instead of copying #7
Conversation
Hi, thanks a bunch! This looks amazing! Before I go ahead with the merge, I have to ask, does this work as expected on Windows and Linux? Btw, if you don't have access to those operating systems, let me know and I'll test it 👍 |
@virejdasani I only have Macs so would appreciate you testing this on the other OS'es :) |
Sure thing, I'll test it :) |
@virejdasani any thoughts or updates on this? |
@tomershvueli, I'm sorry for getting back to you this late, I've been quite busy with school. |
@virejdasani no worries, school and studies definitely comes first :) From the screen capture it looks like you might be on the |
Oh yea, I see what I did there, my bad 😅 |
Weird.. that same |
Still no luck. Let me try and find another way 👍 |
For some reason, there are errors when installing RobotJS. After some research, I found that there are other people who have raised this issue on their GitHub but it hasn't been resolved yet. Furthermore, I've tested it on Linux and the install fails on there too. |
@virejdasani RobotJS definitely presented some issues. However, this node-key-sender, while also looks like it'll get us what we want, introduces Java into the mix, since the package just seems to be a wrapper around a Java jar file - are you ok with that? If so, I can try to switch out RobotJS for this node-key-sender! |
@tomershvueli, I think node-key-sender is the way to go, for this feature, because RobotJS is getting us nowhere |
@virejdasani I appreciate the decisiveness! I gave node-key-sender a whirl but it seems it's not working on my Mac :( it opens up a Java application, but in the foreground, meaning any 'typing' it does does not actually get transferred to the window the user intended it. See screenshot: |
It sucks that this didn't work out. I'll try to play around with the code or find a new library or try getting RobotJS working. Either way, I'll keep you posted 👍 |
Thanks @virejdasani, let me know if I can help in any other way! |
@tomershvueli, I finally have some good news. After a little research, I found that when you upgrade or downgrade your MacOS version, the Xcode command line tools have to be reinstalled or they are undiscoverable. I had just downgraded from Monterey Beta back to Big Sur. After reinstalling the tools, I tried reinstalling write-moji and now it works! |
@virejdasani neat idea! I just pushed up a commit that will allow a user to copy the emoji if they select an emoji while holding down a Shift key instead of Control. The reason is that this is very easy to detect in JS, so the change is relatively trivial. Let me know your thoughts! |
This works perfectly! |
@tomershvueli, I have created a new branch from the master called |
@virejdasani, see PR #9. |
This addresses feature request #6.
This is a major chance of functionality so I will leave it to @virejdasani if they want Geniemoji to go in this direction.
Note that RobotJS seems to require explicit permissions on macOS. When the user first will run this application, a pop up will appear that will require them to give Geniemoji permissions in order to type on the user's behalf. See below images:
See functionality in action below: